cute_noker@feddit.dk to Programmer Humor@programming.dev · 6 days agois my PR big enough ?feddit.dkimagemessage-square39fedilinkarrow-up1199arrow-down14
arrow-up1195arrow-down1imageis my PR big enough ?feddit.dkcute_noker@feddit.dk to Programmer Humor@programming.dev · 6 days agomessage-square39fedilink
minus-squareFMT99@lemmy.worldlinkfedilinkarrow-up4·6 days agoI err on the side of splitting because of what Scratch just said. If I give my colleague 2k lines to review it’ll get slapped with a LGTM and passed. If I send them 100 lines they’ll actually look at it.
minus-squareBoomkop3@reddthat.comlinkfedilinkarrow-up2·6 days agoLooks good to me, are you getting the rocket?
I err on the side of splitting because of what Scratch just said. If I give my colleague 2k lines to review it’ll get slapped with a LGTM and passed. If I send them 100 lines they’ll actually look at it.
LGTM= let’s go to the moon?
Looks good to me, are you getting the rocket?